Michael Telatynski
Michael Telatynski
Needs DCO sign-off https://github.com/matrix-org/matrix-js-sdk/blob/master/CONTRIBUTING.rst#sign-off
Yup, that is fine :)
The tray icon gets overridden by the app favicon when you get a notification, so this would cause your icon to flicker between custom and element, no?
@3nprob what OS did you test on? We only don't use the favicon override on macOS, where the OS has stable notification bubble count support so we can skip it
https://github.com/vector-im/element-desktop/blob/61ed2a21c68f6d41fb57d103db6e025779eafcc7/src/tray.ts#L64-L93 is the bit responsible
> Would this support svgs? That probably depends on your OS, Electron docs don't specify other than a recommendation to use `ico` on Windows
Riot doesn't use the RM (`m.fully_read`) for calculating number of unreads, it uses the Read Receipt
the RM is used to `Jump to first unread message.` only. 
Relevant: https://github.com/vector-im/riot-meta/issues/66
In theory it should work, the return here (https://github.com/marcoschwartz/LiquidCrystal_I2C/blob/master/LiquidCrystal_I2C.cpp#L12) is what broke a lot of similar libraries.