set-timezone icon indicating copy to clipboard operation
set-timezone copied to clipboard
verified publisher icon szenius

Fixed README to have correct version usage

Open jodysimpson opened this issue 1 year ago • 2 comments

Update to v2.0 provided incorrect usage documentation

jodysimpson avatar Apr 16 '24 16:04 jodysimpson

@szenius can you create and push a new tag based on the current master

git tag v2
git push origin v2

kwarkjes avatar Apr 18 '24 18:04 kwarkjes

CMIIW but v2 will automatically point to latest v2.X version right?

szenius avatar Apr 25 '24 11:04 szenius

@szenius It does not in this case. GH actions use the @xxx as a git reference to checkout the repo. In this case the git tag v2 does not exist. we only have v2.0

  • Either we have to push a git tag v2 so that reference can be resolved while cloning the repo
  • Change the README file and refer the the v2.0 tag instead

I believe that the pattern v2 as a versioning is more common and should be recommended in this case

kwarkjes avatar May 07 '24 12:05 kwarkjes