systemli
Recovery process: Wrong calculation of waiting period
Apparently there's a bug in calculating the waiting period for recovery processes. When starting the recovery process, I get told that I have to wait at least 48 hours, but at the same time I'm told that the second step is possible earliest in five days from now: The displayed timestamp is five days in the furture, not two.
Interestingly, after reloading the recovery process page, the correct timestamp is displayed: 48 hours (two days) after the process has been started.
Well, the problem seems to be that DateTime::add() manipulates the underlying DateTime object.
Since we execute $time->add(new \DateInterval('P2D')) twice in the first run (once in RecoveryProcessMessageSender and once in RecoveryController), the timestamp after the second invocation has four days added, not two.
I didn't find a good solution to fix this yet.