si icon indicating copy to clipboard operation
si copied to clipboard

Switch to new asset details panel paradigm

Open nickgerace opened this issue 1 year ago • 1 comments

Description

This PR ensures that we retain func bindings when regenerating assets and switches to the new asset details panel paradigm, which replaces setValueFrom and it enables intrinsic func authoring for all.

The bug was caused by relying on the identity func when merging prototypes for both prop and socket output locations between two schema variants. Now, conditional logic based on the identity func has been removed because identity func bindings now work similarly to custom attribute func bindings: both involve editing the asset, but not the asset's code.

As a result of these changes, setValueFrom will now "no-op" and will notify the user accordingly when they use it. This does not affect existing assets as they will go through the import and export module code rather than through asset func execution. In addition, the identity-based bindings will appear in the asset details panel. However, the next time that the asset func is regenerated, setValueFrom will "no-op" and only the bindings in the asset details panel will be respected.

This PR also fixes tracing naming for the regenerate_variant function.

nickgerace avatar Sep 19 '24 21:09 nickgerace

We are going to discuss how to do this and when's the best time. Moving to drafts.

nickgerace avatar Sep 25 '24 01:09 nickgerace