systemd-bootchart icon indicating copy to clipboard operation
systemd-bootchart copied to clipboard

WIP: fix post-switch-root file operations

Open jamuir opened this issue 11 months ago • 4 comments

Share the first part of the Cisco patch authored by Oleksiy Obitotskyy to fix reading from /proc/schedstat post-switch-root (see #60).

More changes are needed since writing the svg file fails.

jamuir avatar Feb 19 '25 17:02 jamuir

@sofar : this is WIP, but please share any comments you might have.

There is some code duplication.

jamuir avatar Feb 19 '25 17:02 jamuir

Please change the patch title to something other than "WIP 1". Looks okay in general, just some small remarks from me.

sofar avatar Feb 19 '25 20:02 sofar

Please change the patch title to something other than "WIP 1". Looks okay in general, just some small remarks from me.

I will create a better commit message after I finish the next part (i.e. fixing the writing of the svg file). This is still a draft PR.

jamuir avatar Feb 21 '25 13:02 jamuir

Just put WIP in the title of the PR. Nothing wrong with iterative development imho. Once you're ready for merging, I would squash together your commits into coherent changesets.

sofar avatar Feb 21 '25 17:02 sofar