casync icon indicating copy to clipboard operation
casync copied to clipboard

Use libdir to install protocols

Open bl33pbl0p opened this issue 7 years ago • 6 comments

We pass something like:

meson --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/bin
--libdir=/usr/x86_64-pc-linux-gnu/lib --libexecdir=/usr/x86_64-pc-linux-gnu/libexec ...

in exherbo, where /usr/lib is symlinked to /usr/$TARGET/lib, /usr/bin -> /usr/$TARGET/bin, and so on, but before this change they would be installed to /usr/lib, which does not work since that is a symlink as described above, so use the passed libdir to install protocols. Other *dirs were working correctly.

bl33pbl0p avatar Mar 06 '18 12:03 bl33pbl0p

It would also be nice to have a release soon, preferably after this gets merged. =)

bl33pbl0p avatar Mar 06 '18 12:03 bl33pbl0p

Something like this was attempted and rejected in https://github.com/systemd/casync/pull/106

fsateler avatar Mar 06 '18 13:03 fsateler

ping

bl33pbl0p avatar Jan 13 '19 17:01 bl33pbl0p

OK, OK, let's make this work. But please change the patch so that the default remains as it is now, and make libexecdir overridable. If -Dlibexecdir, install under libexecdir/casync, and otherwise keep the path that is used now.

keszybz avatar Jan 24 '19 22:01 keszybz

@bl33pbl0p ?

keszybz avatar Apr 25 '19 06:04 keszybz

Sorry, I kept missing this all this time.

Is this close to what you wanted (I'm not really great at meson)?

@keszybz

bl33pbl0p avatar Apr 25 '19 16:04 bl33pbl0p