Joe Adams

Results 155 comments of Joe Adams

I'm not sure exactly what you are asking about. The `collector="bgwriter"` you reference is only part of our logging as far as I can see which has nothing to do...

[According to the docs ](https://www.postgresql.org/docs/current/monitoring-stats.html#MONITORING-PG-STAT-ACTIVITY-VIEW) the xact_start field can be NULL when no transaction is active. Looking at the code, I'm not entirely sure what the meaning of the metric...

Because I don't understand the meaning of the metric, I will defer the choice to someone else. Maybe @SuperQ. My feedback: 1. The `IS NOT NULL` condition could mean the...

Merged via #1048

In the case of a single stat graph in the dashboard, you really want a single value or metric. The sum() function does help provide that in case there are...

As for the original request, the `--collector.clustersettings` argument exports cluster settings metrics including watermark settings. i.e. ``` # HELP elasticsearch_clustersettings_allocation_watermark_flood_stage_ratio Flood stage watermark as a ratio. # TYPE elasticsearch_clustersettings_allocation_watermark_flood_stage_ratio gauge...

That is correct. We don't have any metrics for indexing_pressure today.

I don't have time to do a full review at this moment, but I am always hesitant of adding more dependencies. Particularly in this case, the mapstructure project has been...

It does appear that the docs are just out of date. You should be able to provide the same config to both.

I think this might be a good time to add pprof [like we did in the elasticsearch_exporter](https://github.com/prometheus-community/elasticsearch_exporter/pull/1033) to help us uncover what is using the memory. What do you think...