Keyboard shortcuts for player

Open manas94gupta opened this issue 7 years ago • 3 comments

Added keyboard shortcuts to play/pause, forward/backward, speed up/down and volume up/down for the player. Added a small line in player section to view all the shortcuts.

Aug 17 '18 04:08 manas94gupta

hey is it possible you can send this change in without reformatting everything ?Thanks a ton!

Aug 22 '18 15:08 wesbos

Hey! Thanks for the heads up. Just updated the formatting. Let me know if any other change is required.

Aug 23 '18 04:08 manas94gupta

@manas94gupta Hey Manas! It looks like you have some cases that don't do anything. Is that on purpose? Also, your comment for moving forward/backward is saying it's x0.10. Is it not x0.25? Also, keypress will keep firing if a user keeps the key pressed, maybe it's better to use keyup? Lastly, your commit has some conflicts because of some new updates to the player (missing tooltip in state) maybe grab a fresh version of master and try again?

Oct 22 '18 23:10 sergical