NAppUpdate icon indicating copy to clipboard operation
NAppUpdate copied to clipboard

Incorrect file version check for text files

Open firsinanton opened this issue 8 years ago • 1 comments

FeedBuilder generates version"0.0.0.0" for text files (such as .config files). If we generates with CompareVersion=True, it includes for that files the following condition: <FileVersionCondition type="or" what="below" version="0.0.0.0" />

While checking for update it checks this version with the version of text file, and version becomes null: (FileVersionCondition.cs: 37)

var versionInfo = FileVersionInfo.GetVersionInfo(localPath); if (versionInfo.FileVersion == null) return true; // perform the update if no version info is found

And in this case NAppUpdate thies to update these files every time, even they are binary equal to each other.

firsinanton avatar Feb 02 '18 10:02 firsinanton

Either FeedBuiler should check if FileVersion is null, and do not generate FileVersionCondition for such files; or you should change FileVersionCondition behavior in such situations; or FeedBuilder should have smarter settings capabilities, for example, possibility to set different conditions for each files

firsinanton avatar Feb 02 '18 10:02 firsinanton