Sym Roe

Results 68 comments of Sym Roe

I think you're right that we're not going to care about `created` _very much_, but at the same time it might be confusing in future to have a load of...

Last time I looked, Wikipedia was wrong for every party I checked… …and none of the lists agreed with each other… But yes, this is a nice idea, no matter...

I think this should be implemented with https://docs.python-requests.org/en/latest/user/quickstart/#timeouts

Yep! But also, this issue is still valid, for example we see higher latency sometimes when deploying WDIV. We don't want that site to take down this site, so catching...

Guidance here: > In general, it is better not to open new windows and tabs since they can be disorienting for people, especially people who have difficulty perceiving visual content....

In the past we've included the hustings for a ballot on the postcode page: https://github.com/DemocracyClub/WhoCanIVoteFor/commit/7cfbb702b62509f173397f7b12b60bcb357fd604#diff-ba8a90759360c60a22821bad430a05de0da3522971ea17534c5c135d0244bdbbL142 I removed this when I was DRYing up the templates, but we should add them...

Good points. The Who logger is a bit easier to migrate as the logging is done in an async way, so DB downtime doesn't take the site down!

Site map still not done, but we now title by-elections properly, so that might help

To expand this a little: [`FAIL_INVALID_TEMPLATE_VARS` is a feature of pytest-django ](https://pytest-django.readthedocs.io/en/latest/usage.html#fail-on-template-vars-fail-for-invalid-variables-in-templates) that will check if a template is trying to use a variable from the context that doesn't exit....

Ah good catch, there is some conversation about this here, that I'd forgotten about until now: https://github.com/DemocracyClub/UK-Polling-Stations/pull/2899