symfony
Add access_control rule for form login auth
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #396 |
| License | MIT |
Add access_control rule when make:auth command is used with login form authenticator
Hello, Thank you for this PR, sorry for the delay in reviewing it. The feature sounds nice. Does it support merging rules with already existing acces_control rules? We should not break user config.
Hello, Thank you for this PR, sorry for the delay in reviewing it. Does it support merging rules with already existing acces_control rules? We should not break user config.
Hi! Yes, it's done here: If an existing config is detected, the line is not added. The test case name is simple_security_with_access_control
Hiya!
This generally look very good (including the tests). But, I think I need to do a bit of work on YamlSourceManipulator to allow for the access_control to be inline as we really want. Also, I find a few edge-cases with it - like if the security.yaml file looks like the recipe - https://github.com/symfony/recipes/blob/master/symfony/security-bundle/4.4/config/packages/security.yaml - where it has access_control set to no value, then with 2 lines of comments, those comments end up in a screwy place. I'd like to get that done, then this PR (which is already perfect for what it does) should be ready
