maker-bundle icon indicating copy to clipboard operation
maker-bundle copied to clipboard

[make:entity] `generate()` call to `is_string()` appears to always evaluate to `false`

Open jrushlow opened this issue 2 years ago • 1 comments

https://github.com/symfony/maker-bundle/blob/f7ee2503fbea634f2e8c30170a8ad8bd0e3d378f/src/Maker/MakeEntity.php#L309

I believe $manipulatorOrMessage is always an instance of ClassSourceManipulator but I may be wrong. This could be an artifact leftover from previous versions where we did display a message. We need to confirm what use case would cause this not to be an instance of CSM.

For debugging:

  • change the conditional to $manipulatorOrMessage instanceOf ClassSourceManipulator -> getSourceCode() && exit early.
  • then attach breakpoint || dump($manipulatorOrMessage) in the else statement.

jrushlow avatar Apr 05 '24 15:04 jrushlow

Hello @jrushlow I can work on this if nobody started :D

RazielRodrigues avatar Dec 02 '24 17:12 RazielRodrigues