maker-bundle icon indicating copy to clipboard operation
maker-bundle copied to clipboard

[make:auth] Adapt command to use the upcoming LogoutRouteLoader

Open maelanleborgne opened this issue 2 years ago • 1 comments

This PR has been merged a few days ago : https://github.com/symfony/symfony/pull/50946 We now don't need to make a controller to match the logout path, we just need to register a route loader that deals with loading a route for each firewall that has a logout.path.

It would be nice to have this change reflected in the make:auth command.

I've started to work on this, but I'm not sure if there are any plan to release a new version of the maker-bundle with minimum compatibility with symfony 6.4 / 7, or if I should test if the new LogoutRouteLoader service exists and change the behaviour accordingly.

maelanleborgne avatar Oct 17 '23 09:10 maelanleborgne

Hey!

I've started to work on this, but I'm not sure if there are any plan to release a new version of the maker-bundle with minimum compatibility with symfony 6.4 / 7, or if I should test if the new LogoutRouteLoader service exists and change the behaviour accordingly.

That's an excellent question. The next release will still probably require 6.3, so we should test for the LogoutRouteLoader service and generate the code conditionally. We're going to be a little more strict on MakerBundle version support (i.e. support less versions of Symfony at a time), but I think the next release will still be ^6.3|^7.0

Thanks :)

weaverryan avatar Oct 17 '23 13:10 weaverryan