symengine.py icon indicating copy to clipboard operation
symengine.py copied to clipboard
verified publisher icon symengine

Requesting update the simplify function

Open JJShi92 opened this issue 3 years ago • 4 comments

Hi, The simplify function here still calls sympy, which is really time consuming. Since symengine has already implemented its own simplify function. Could you please update the simplify function as well as add the refine function here accordingly (https://github.com/symengine/symengine/issues/1520). Thank you very much

JJShi92 avatar May 21 '22 15:05 JJShi92

Thanks for reporting this. Although the refine and simplify are not nearly as mature as the ones in sympy, I think we should use the ones in symengine here. If the user wants to use sympy to simplify that would still be possible, by calling sympy directly. I guess this is legacy from a time when symengine didn't have any similar functionality.

rikardn avatar Aug 04 '22 17:08 rikardn

How is the status of this enhancement?

Goulustis avatar Sep 21 '23 09:09 Goulustis

I would also appreciate this. What is currently holding this back? Doesn't the simplify function just need to be added in the wrapper?

adrian-kriegel avatar May 04 '24 19:05 adrian-kriegel

Yes, it needs to be added. This also requires the Assumptions class to be added somehow and this might not be as straight forward. Any ideas on how to wrap this for Python?

rikardn avatar May 06 '24 11:05 rikardn