swift icon indicating copy to clipboard operation
swift copied to clipboard

Compiler error when extending a typealias of a partially specialized generic type #68212

Open xavgru12 opened this issue 2 years ago • 12 comments

Resolves #68212.

xavgru12 avatar Apr 21 '24 17:04 xavgru12

@swift-ci please smoke test Linux

AnthonyLatsis avatar Apr 21 '24 19:04 AnthonyLatsis

i was curious to see how this was solved and guess I was overcomplicating the issue 😭

saehejkang avatar Apr 21 '24 19:04 saehejkang

This is far from solved, FWIW 🙂. I only triggered the tests to encourage the author to iterate on failures before any feedback arrives.

AnthonyLatsis avatar Apr 21 '24 19:04 AnthonyLatsis

Is it possible to make this PR as a draft?

xedin avatar Apr 24 '24 20:04 xedin

I was converting to draft but Anthony was faster

xavgru12 avatar Apr 24 '24 21:04 xavgru12

For posterity, the convert to draft button is at the bottom of the Reviewers section.

AnthonyLatsis avatar Apr 24 '24 21:04 AnthonyLatsis

@swift-ci please smoke test Linux

xavgru12 avatar Mar 11 '25 18:03 xavgru12

I forgot that I am not able to start the CI lol

xavgru12 avatar Mar 21 '25 20:03 xavgru12

deleted and pushed branch in order to trigger CI

xavgru12 avatar Mar 31 '25 18:03 xavgru12

@AnthonyLatsis check this out

xavgru12 avatar Apr 02 '25 06:04 xavgru12

merged main again, smoke test Linux was green already

xavgru12 avatar Apr 03 '25 11:04 xavgru12

@AnthonyLatsis I see you have been quite busy with 6.1 these days. Could you review this?

xavgru12 avatar Apr 09 '25 10:04 xavgru12

@swift-ci please smoke test macOS

AnthonyLatsis avatar Apr 13 '25 18:04 AnthonyLatsis

Will have a review ready by Monday.

AnthonyLatsis avatar Apr 13 '25 18:04 AnthonyLatsis

@AnthonyLatsis I changed the code according review and added test cases. Let me know what you think about this.

xavgru12 avatar May 04 '25 12:05 xavgru12

@AnthonyLatsis reminder

xavgru12 avatar May 18 '25 20:05 xavgru12

You once said a ping every two weeks is fine. So here I am pinging you @AnthonyLatsis

xavgru12 avatar May 31 '25 06:05 xavgru12

@AnthonyLatsis I iterated over it and added some comments unresolving threads. Please review again and I hope you are able to keep the overview over this, so let me know if something is unclear.

xavgru12 avatar Jun 05 '25 17:06 xavgru12

@AnthonyLatsis reminder

xavgru12 avatar Jun 16 '25 16:06 xavgru12

@AnthonyLatsis another reminder, not sure if it was 2 weeks ago as Github suggests

xavgru12 avatar Jun 27 '25 18:06 xavgru12

@AnthonyLatsis another reminder

xavgru12 avatar Jul 11 '25 15:07 xavgru12

@slavapestov Could you take a look at this too?

AnthonyLatsis avatar Jul 14 '25 17:07 AnthonyLatsis

@AnthonyLatsis It has been some time. I think this is close to a good solution

xavgru12 avatar Sep 10 '25 20:09 xavgru12

@AnthonyLatsis could you have a look?

xavgru12 avatar Sep 21 '25 08:09 xavgru12

@AnthonyLatsis @slavapestov Could someone have a look at it, so I can iterate further on it if required?

xavgru12 avatar Oct 04 '25 09:10 xavgru12

@AnthonyLatsis

xavgru12 avatar Nov 03 '25 21:11 xavgru12

swift typecheckdecl isGeneric seems to have changed since last time I worked on it. Can be reviewed either way though

xavgru12 avatar Nov 15 '25 09:11 xavgru12