http

http copied to clipboard

Proposal: Some suggestions for better, more readble API

8

I don't know where I can submit proposals for api changes so I opened this issue. ### HTTPServer port server port is determined in `start(port:, handler:)` method, while I think...

amosavian

We should agree upon a style guide

3

Noticed that we don't seem to have an official style guide that we adhere to. I think it would be nice if we could pick one as we could encode...

anayini

In #96, @helje5 noted that the number of `queues` that we use in the `HTTPServer` should be lifted up into the `Options` Just tracking that thought here.

anayini

In HTTPServer specification, `Port:0` give error, should be `Port:nil` for kernel assigned ports

6

Based on comments from @helje5: Don't do port: 0, should raise an error. Do port: nil for kernel assigned, or a real port

gtaban

Determine the lifecycle of the HTTP server. Refer to the discussions from #82 for history. An initial idea discussed in that PR is: > - init: sets up the server...

gtaban

Revisit potential use of string.utf8 field for conversion to data

1

See PR #20 for history. Need to revisit this after #96 is complete and we have a perf baseline.

carlbrown

Support for multiple addresses per server

1

From @helje5: https://github.com/swift-server/http/pull/81#issuecomment-342630664 An open question is, do we want to support multiple binds? I tend to say yes. This would modify the structure of the server a little. (the...

gtaban

Use sockaddr structure instead of port for connection address

6

From comments by @helje5 in #81 `Port` is insufficient. We need to allow an (or many!) arbitrary `sockaddr_in` (either via sockaddr_in or a wrapper). If only to allow IPv6 and...

gtaban

The use of closure as associated value of the processBody case feels unusual

3

I've been looking through example code for the HTTP library and the use of a associated value closure for the `HTTPBodyProcessing.processBody` case feels kind of usual. I've never seen such...

hartbit

Honor stop (Bool) flag in HTTPBodyHandler

1

The current implementation doesn't honor the `stop` flag (the `inout Bool`) in `HTTPBodyHandler`. Need to fix that and write a test for it.

carlbrown