python-novice-inflammation icon indicating copy to clipboard operation
python-novice-inflammation copied to clipboard

Lesson contribution: Alternate diagrams for lists of lists (variation on the pepper photos)

Open kris-joseph opened this issue 4 years ago • 2 comments

The section on nested lists in the "Storing Multiple Values in Lists" episode makes reference to a grocery shelf, but the image presented is of a pepper packet in a pepper shaker and I find the mixed analogy difficult to follow as a learner.

I'd like to propose leaning more heavily on the grocery idea by providing images that illustrate the example. I've created a few graphics that I think could serve if implemented alongside some tweaking to the example and text:

A full nested-list object: groceries_x

Dividing the nested list into rows: groceries_x0

Addressing each "slot" on the grocery shelf: groceries_x00_v2

It would replace the pepper image and add two more, but I think it might help learners understand the referencing a bit more clearly.

I'd be happy to put in a pull request and make the changes....?

kris-joseph avatar Aug 27 '21 15:08 kris-joseph

Thank you, @kris-joseph! I like these images a lot -- bright, colorful, clear. I also like the transparency level and colors you used for tags (light semitransparent gray background with white text). I guess we'd want to crop the images along the outer edges of top/bottom white lines and make positions of all tags consistent between the images.

Anyways, before you puts any more work into this, let us ask what other maintainers have to say about it. CC @swcarpentry/python-novice-inflammation-maintainers

maxim-belkin avatar Aug 27 '21 15:08 maxim-belkin

This visual explanation makes more sense to me than the pepper shaker/packets that are currently in the lesson, as I think the shaker with the single packet after seeing the shaker with multiple packets can be confusing with [x[0]]. I like how @kris-joseph is using the grocery shelf context like the text too. I vote for moving forward with this change. Thank you very much, @kris-joseph for proposing this and offering to implement changes and @maxim-belkin for the technical critique.

ldko avatar Aug 27 '21 15:08 ldko