plugins icon indicating copy to clipboard operation
plugins copied to clipboard

emotion plugin should not use `Path::new`

Open kdy1 opened this issue 3 years ago • 2 comments

https://github.com/swc-project/plugins/blob/4e75423a873b25f1526d29b51b74bff1475467fd/packages/emotion/src/lib.rs#L76

This will be broken on windows

kdy1 avatar Aug 25 '22 08:08 kdy1

I ran the emotion fixture suite and builds on windows to see if this was still an issue and it seems to work now, is this what you find too? Can probably close this if so

Codex- avatar Jan 12 '24 22:01 Codex-

@Codex- The problem is that the plugin is compiled as a Wasm binary, which uses / as the path separator even on windows.

kdy1 avatar Jan 30 '24 08:01 kdy1