swagger-ui
swagger-ui copied to clipboard
fix(request-duration): Set response duration in failure cases
Description
Request duration is not being populated for non-200 responses
According to live-response.jsx the duration component will only be rendered if the response duration is set
https://github.com/swagger-api/swagger-ui/blob/master/src/core/components/live-response.jsx#L124
But that was not happening on the 'catch' block https://github.com/swagger-api/swagger-ui/blob/master/src/core/plugins/spec/actions.js#L471-L487
Motivation and Context
Fixes #6618
How Has This Been Tested?
Unit tests
Screenshots (if appropriate):
Checklist
My PR contains...
- [ ] No code changes (
src/is unmodified: changes to documentation, CI, metadata, etc.) - [ ] Dependency changes (any modification to dependencies in
package.json) - [x] Bug fixes (non-breaking change which fixes an issue)
- [ ] Improvements (misc. changes to existing features)
- [ ] Features (non-breaking change which adds functionality)
My changes...
- [ ] are breaking changes to a public API (config options, System API, major UI change, etc).
- [ ] are breaking changes to a private API (Redux, component props, utility functions, etc.).
- [ ] are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
- [x] are not breaking changes.
Documentation
- [x] My changes do not require a change to the project documentation.
- [ ] My changes require a change to the project documentation.
- [ ] If yes to above: I have updated the documentation accordingly.
Automated tests
- [ ] My changes can not or do not need to be tested.
- [x] My changes can and should be tested by unit and/or integration tests.
- [x] If yes to above: I have added tests to cover my changes.
- [ ] If yes to above: I have taken care to cover edge cases in my tests.
- [x] All new and existing tests passed.