kit icon indicating copy to clipboard operation
kit copied to clipboard

fix: exclude service worker directory from tsconfig

Open gurpreetatwal opened this issue 1 year ago • 2 comments

The docs state that the service worker can be located at src/service-worker.js or as an index.js file within the src/service-worker directory.

Without this fix users who place the file within the directory run into Typescript errors like #11721

Follow up to #11727

Question for maintainers: Should all js/ts files in the service-worker directory be excluded or only index.js|ts|d.ts?


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

gurpreetatwal avatar May 07 '24 19:05 gurpreetatwal

🦋 Changeset detected

Latest commit: 144ff7157bad8efb8e1ed185a1ac0d40570ab981

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 07 '24 19:05 changeset-bot[bot]

@dummdidumm, @trueadm , @eltigerchino sorry for the ping but would one of you be able to take a look at this PR?

gurpreetatwal avatar Aug 28 '24 15:08 gurpreetatwal

Thank you!

teemingc avatar Aug 29 '24 08:08 teemingc