kit icon indicating copy to clipboard operation
kit copied to clipboard
verified publisher icon sveltejs

chore: overhaul ignore configs

Open hyunbinseo opened this issue 2 years ago • 1 comments

Update git, Prettier, and ESLint ignore files.

  1. Sort items alphabetically.
  2. Categorize items into OS, Vite, and Lockfiles.
  3. Remove the leading / - match the style with the node_modules entry.
  4. Follow the Vite's .env file rules - only the *.local files are ignored by git.
  5. Remove items from .eslintignore that are not handled by ESLint, such as .DS_STORE.
  6. Add items to .eslintignore, such as dist which is generated in the library template.
  7. Add Thumbs.db for Windows users.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

hyunbinseo avatar Feb 22 '24 11:02 hyunbinseo

⚠️ No Changeset found

Latest commit: 41bb2c0fc752843651e00de133da618884c2c5ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 22 '24 11:02 changeset-bot[bot]

@benmccann I am really sorry, I badly messed up my git branching.

Should I create a new PR with the above mentioned suggestions?

hyunbinseo avatar Mar 05 '24 14:03 hyunbinseo

Go for it @hyunbinseo

ghostdevv avatar Mar 05 '24 18:03 ghostdevv