File icons are aligned to top of tab

[arda-]

When using the package file icons, the icons seem to be aligned to the top of the tab instead of the window. This occurs with many different file types.

Here are a variety of remotely opened files:

Here is a remotely opened file next to a local one:

Not quite sure whether this is an issue more appropriate for your project, or the other! I posted to both, just in case.

[sdbarron]

A local file has only a class of "title" while a remote-edit item has "title icon icon-globe". It seems as if remote-edit is trying to do icon functionality (which sounds good) but it's incompatible with at least _this _other icon package.

Commenting out

    getIconName: ->
      "globe"

from remote-edit-editor.coffee takes care of it but is probably not the correct long-term solution.

@alhadis is patching file-icons now.

[Alhadis]

Yup, patched.

@sveale You can prevent styling tabs when File-Icons is in effect by wrapping the CSS in this:

body:not(.file-icons-tab-pane-icon){

    .icon-globe::before{
        font-family: 'Octicons Regular';
        font-weight: normal;
        font-style: normal;
        display: inline-block;
        line-height: 1;
        -webkit-font-smoothing: antialiased;
        text-decoration: none;
        font-size: 16px;
        width: 16px;
        height: 16px;
        content: "\f0b6";
    }
}