supermosh.github.io icon indicating copy to clipboard operation
supermosh.github.io copied to clipboard

Check for "Segment has a length of 0s" is incorrect

Open hmcq6 opened this issue 1 year ago • 1 comments

Description

To Recreate

  1. Upload a video clip
  2. Add a Copy Segment of 1s
  3. Add a Glide Segment at Time = 0 where the Length != 0
  4. Render

To Fix

Change segment.time to segment.length https://github.com/supermosh/supermosh.github.io/blob/6190f690ef4b0c8048ec8e4bea142f0e9bc62ea7/app/src/Render.tsx#L47

Screenshots

Screenshot 2024-12-12 at 5 41 24 PM

Logs

No response

Browsers

Chrome

OS

Mac

hmcq6 avatar Dec 12 '24 22:12 hmcq6

Thanks for the detailed bug report, I'll look into it asap

ninofiliu avatar Dec 13 '24 12:12 ninofiliu

This is a v1 bug, the v2 was released and it's a ground up rewrite, closing this but thanks for reporting!

ninofiliu avatar Jun 16 '25 13:06 ninofiliu