super_editor icon indicating copy to clipboard operation
super_editor copied to clipboard
verified publisher icon superlistapp

Fix TagFinder.findTagAroundPosition for better emoji support

Open BazinC opened this issue 2 years ago • 7 comments

Fixes https://github.com/superlistapp/super_editor/issues/1863 and https://github.com/superlistapp/super_editor/issues/1882

  • fixed findTagAroundPosition to support of emojis
  • Widget Text: added "emojis" group and "with consecutive triggers" in "commits" group. There was edge case in findTagAroundPosition looping through the parameter text code point one by one. Fixed it with characters iterators.

BazinC avatar Mar 12 '24 18:03 BazinC

golden test fails, I didn't manage to update them.. Can you help me with it?

BazinC avatar Mar 12 '24 18:03 BazinC

@matthew-carroll @angelosilvestre

BazinC avatar Mar 12 '24 18:03 BazinC

Ready for another review @matthew-carroll

BazinC avatar Mar 13 '24 00:03 BazinC

@BazinC any progress on this?

matthew-carroll avatar Mar 22 '24 20:03 matthew-carroll

@BazinC checking in one last time - do you plan to update this?

matthew-carroll avatar Apr 10 '24 18:04 matthew-carroll

@BazinC checking in one last time - do you plan to update this?

Sorry @matthew-carroll I didn't have time yet. I will give another try tomorrow (I'm afk right now)

BazinC avatar Apr 10 '24 20:04 BazinC

@BazinC please be sure to re-request a review whenever you think you've handled the feedback.

matthew-carroll avatar Apr 18 '24 00:04 matthew-carroll

I'm gonna take over this PR to get it merged in: https://github.com/superlistapp/super_editor/pull/2046

matthew-carroll avatar May 26 '24 22:05 matthew-carroll