control icon indicating copy to clipboard operation
control copied to clipboard

2.0: API Review installation templates

Open saheienko opened this issue 7 years ago • 2 comments

There are a few checks with usage of until loop that will hang indefinitely in case of error.

For instance: https://github.com/supergiant/control/blob/release-2.0/templates/poststart.tpl#L4

saheienko avatar Dec 05 '18 10:12 saheienko

@saheienko Is this still an issue?

eldridgeh avatar Apr 30 '19 15:04 eldridgeh

@eldridgeh yes, there are a few ones:

templates/clustercheck.sh.tpl:1:until $([ $(sudo kubectl get nodes|grep Ready|grep master|wc -l) -ge 1 ]); do printf '.'; sleep 5; done
templates/network.sh.tpl:5:until $([ $(sudo kubectl get po -n kube-system|grep apiserver |grep Running|wc -l) -ge 1 ]); do printf '.'; sleep 5; done

saheienko avatar Apr 30 '19 16:04 saheienko