control
control copied to clipboard
2.0: API Review installation templates
There are a few checks with usage of until loop that will hang indefinitely in case of error.
For instance: https://github.com/supergiant/control/blob/release-2.0/templates/poststart.tpl#L4
@saheienko Is this still an issue?
@eldridgeh yes, there are a few ones:
templates/clustercheck.sh.tpl:1:until $([ $(sudo kubectl get nodes|grep Ready|grep master|wc -l) -ge 1 ]); do printf '.'; sleep 5; done
templates/network.sh.tpl:5:until $([ $(sudo kubectl get po -n kube-system|grep apiserver |grep Running|wc -l) -ge 1 ]); do printf '.'; sleep 5; done