ui icon indicating copy to clipboard operation
ui copied to clipboard

`Input` component hiding of error icon

Open Ziinc opened this issue 4 years ago • 7 comments

Would be great to have a prop to hide the error icon, currently it shows by default, which in some situations (see below) would make the input bar actions area even more cluttered. Currently no way to hide it once the error prop is provided.

image

Ziinc avatar Jan 18 '22 15:01 Ziinc

great idea!

MildTomato avatar Jan 18 '22 16:01 MildTomato

@MildTomato Can I try this one? Also, shouldn't the error icon be with the error msg instead of within the input component?

FatumaA avatar Jan 19 '22 08:01 FatumaA

It might be best to avoid changing anything right now in master branch

I'm about to merge a huge change into the alpha branch, so it might be better to work on changes for this on that branch since I think a lot of the actions container has been refactored.

MildTomato avatar Jan 21 '22 19:01 MildTomato

@FatumaA I think the best action to take might be to just add a new prop, like hideErrorIcon which would stop the icon appearing altogether when error prop is used.

MildTomato avatar Jan 21 '22 19:01 MildTomato

Ok, thanks @MildTomato, I will go ahead and attempt a fix for this then

FatumaA avatar Jan 22 '22 08:01 FatumaA

Is this still an issue? I'd be happy to take another look 🤭

FatumaA avatar Nov 20 '23 20:11 FatumaA

Is this issue still open?

ak708 avatar Apr 05 '24 04:04 ak708