supavisor icon indicating copy to clipboard operation
supavisor copied to clipboard

fix: do not handle errors during connection

Open hauleth opened this issue 1 year ago • 1 comments

This is potential source of a problem, as if there are is error in 2nd or 3rd clause of with then we are leaking connections which in the end may result in the connections exhaustion. Instead we should fail loudly that there is something wrong with the connections. It should also help with debugging potential problems.

hauleth avatar Feb 26 '25 08:02 hauleth

leaking connections

In case of failure in the following cases, the node will not handle notifications because there is no retry logic. So yeah, there’s a potential place for a bug, but it doesn’t lead to leaking connections

abc3 avatar Mar 25 '25 10:03 abc3

@hauleth ~fyi https://github.com/supabase/libcluster_postgres/pull/24~

I've closed that PR because there's already one in progress that adds auto_reconnect. So, to fix the current issue, just need to add auto_reconnect to the notification connection

abc3 avatar May 26 '25 12:05 abc3