postgres icon indicating copy to clipboard operation
postgres copied to clipboard

feat: automate pg_upgrade testing

Open pcnc opened this issue 2 years ago • 6 comments

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

pcnc avatar Jul 11 '23 10:07 pcnc

lgtm, @soedirgo could you give this a once over?

olirice avatar Nov 02 '23 15:11 olirice

Looks great! 👍I guess we don't need to include Testinfra tests since this should only affect PG stuff?

soedirgo avatar Nov 03 '23 09:11 soedirgo

Is it possible to run these tests locally?

steve-chavez avatar Nov 03 '23 14:11 steve-chavez

Sorry I missed this earlier - gave it a quick skim and looks great. Any changes needed to bring it up to speed?

@supabase/postgres any concerns with this change?

Need to follow up on this and merge the more recent upgrade script changes into it. Also want to add tests around encrypted columns (since those are more critical), some extensions such as ltree now that it is possibly problematic, and have pick it up the last ~5 PG releases to cover, besides the configured baseline

@steve-chavez running debug.sh would run this locally, but it requires the scripts and binaries stored in the dev account. I’ll add some docs around this and ping the team in Slack to confirm that everybody can run it

pcnc avatar Nov 03 '23 17:11 pcnc

Looks great! 👍I guess we don't need to include Testinfra tests since this should only affect PG stuff?

Yep! This would run as a parallel check to those, so no dependency between the two workflows

pcnc avatar Nov 03 '23 17:11 pcnc

Will merge after tomorrow's (Jun 13th) prod deploy, to have more ample time for testing the pg_upgrade scripts

pcnc avatar Jun 12 '24 09:06 pcnc