cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: load fallback import map with config

Open sweatybridge opened this issue 1 year ago • 1 comments

What kind of change does this PR introduce?

feature

What is the new behavior?

Not sure if this is the desired approach because functions/import_map.json is a local fallback that's primarily useful for development. When deploying to platform, each function should only declare the import map it needs.

Additional context

Add any other context or screenshots.

sweatybridge avatar Oct 16 '24 00:10 sweatybridge

Pull Request Test Coverage Report for Build 11356904347

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 60.152%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/serve/serve.go 1 2 50.0%
<!-- Total: 2 3
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
<!-- Total: 2
Totals Coverage Status
Change from base Build 11356607401: -0.02%
Covered Lines: 6497
Relevant Lines: 10801

💛 - Coveralls

coveralls avatar Oct 16 '24 01:10 coveralls

closing to encourage declaring import map in config.toml for better isolation https://supabase.slack.com/archives/C02KMRX22NR/p1729522457208809?thread_ts=1729522237.335929&cid=C02KMRX22NR

sweatybridge avatar Oct 25 '24 06:10 sweatybridge