supabase
feat: Add gender, phone, birthdate metadata by kakao provider
What kind of change does this PR introduce?
https://developers.kakao.com/docs/latest/en/kakaologin/rest-api#req-user-info-response-kakaoaccount
Add KaKaoAcount response to metadata
What is the current behavior?
close https://github.com/supabase/gotrue/issues/1445
What is the new behavior?
Add gender, phone, birthdate if exists.
Additional context
These data do not always exist and only exist if the user agrees.
There are many other options that can be brought in from Kakao Is there a reason to add just these 3? For example, we are using name gender birthday birthday birthday phone_number account_ci, etc.
~~실례합니다. 혹시 현재 이 이슈가 어떠한 상황인지 알 수 있을까요..?~~ ~~제가 깃허브 활용에 익숙하지 않아 현재 이슈에 대한 상황을 파악하는데 어려움이 있어서요 ㅜ~~
( 첨부: 아닙니다! 조금 전에 타일러로부터 검토중이라는 답을 받았습니다! )
@MiryangJung
https://github.com/supabase/gotrue/blob/f5ac224d615c59041f902d2d1b3ae20e89ec4e6a/internal/api/provider/provider.go#L30-L68
There is a defined Clams type that encapsulates the structure of user data commonly utilized by providers. This stores metadata provided by the providers.
The purpose of this PR is to add missing data within the current structure.
To meet your requirements, it seems we would need to separately define the data structure for Kakao or extend the common structure, which is beyond the scope of this PR. It might be more appropriate to address this in a separate PR, subject to further discussion with the maintainer.
안녕하세요 미량님 반갑습니다. 😁 provider가 공통으로 사용 중인 사용자 데이터에 대한 구조를 정의한 Clams type이 있습니다. 이는 provider가 제공한 metadata를 저장합니다.
이 PR의 목적은 현재의 구조에서 누락된 데이터를 추가하는 것입니다.
말씀하신 요구사항을 만족하려면 kakao를 위한 데이터 구조를 별도로 정의하거나 공통 구조를 확장해야하는데 그것은 이 PR의 범위를 벗어납니다. 다른 PR에서 작성되어 maintainer와 더 논의가 필요할 것 같습니다.
I didn't understand the overall test structure and didn't add the test code appropriately. Please make appropriate changes or suggestions to the maintainer. And there are still some tests that remain failed due to this addition. Please check this part as well.
