sunpy
[map branch] Reproject tidy
Change reproject_to to use the reproject functionality in NDCube
Remove old reproject import
Remove footprint addition and rely on metadata for information
@ayshih do you know of a more efficient way to compare rsun values than creating this outmap and comparing it to the one on the object?
Contrary to what I wrote here, you'd be fine replacing outmap.rsun_meters with target_wcs.wcs.aux.rsun_ref. That said, it's negligibly more efficient since the reprojected map is made anyway.
thanks @ayshih thanks for clearing up. initially I was looking for a solution with what you'd said previously in mind. I've spoken to Tom and Danny and I think I'm now at the best solution, let me know if you have any further thoughts
Looks like we have a few places now where the warning is raised.
Is the CI passing on the main branch?
@nabobalis true, by the main branch I assume you mean map_ndcube_migration?
okayy, i've hit a slight block currently the new implementation of reproject is giving nans (perhaps resultant coord is off limb?) when pixel_to_world is used on the result of a reproject_to call, @ayshih and @Cadair do you have any ideas on this one?
The CI is now passing on the map_ndcube_migration branch, so we need to fix this.
