sunpy-soar icon indicating copy to clipboard operation
sunpy-soar copied to clipboard

fov table joins added

Open NucleonGodX opened this issue 1 year ago • 7 comments

To implement functionality for plotting curves using Field of View (FoV) values available in SOAR, we needed to first add support for these tables in sunpy-soar. This PR introduces that necessary support for FoV tables.

NucleonGodX avatar Jul 29 '24 20:07 NucleonGodX

Can we make FOV opt in?

nabobalis avatar Jul 29 '24 20:07 nabobalis

Can we make FOV opt in?

Can you explain what you mean by this?

NucleonGodX avatar Jul 30 '24 08:07 NucleonGodX

I've tried to add a functionality, FOV can be passed in the search query with "earth" and "solar" values which would give coordinates with respect to that, if there is no FOV in search query it returns the normal table, if the user passes FOV in search query, depending on the value of it being solar or earth, the user will get all four coordinates.

NucleonGodX avatar Jul 30 '24 13:07 NucleonGodX

Can we make FOV opt in?

Can you explain what you mean by this?

By making it a new attribute a user can add to the query instead of being done all the time.

nabobalis avatar Jul 30 '24 14:07 nabobalis

We should create the example as well. Might as well go all in.

nabobalis avatar Jul 30 '24 14:07 nabobalis

We should create the example as well. Might as well go all in.

Alrighty!

NucleonGodX avatar Jul 30 '24 17:07 NucleonGodX

Looks like the doc test is failing, I'll fix it.

NucleonGodX avatar Aug 02 '24 08:08 NucleonGodX

Hello :wave:, Thanks for your contribution to sunpy! I have marked this pull request as stale because there hasn't had any activity in five months. If you are still working on this, or if it's waiting on a maintainer to look at it then please let us know and we will keep it open. Please add a comment with: @sunpy/sunpy-developers to get someone's attention. If nobody comments on this pull request for another month, it will be closed.

github-actions[bot] avatar Jan 12 '25 05:01 github-actions[bot]

Hello again :wave:, We want to thank you again for your contribution to sunpy! This pull request has had no activity since my last reminder, so I am going to close it. If at any time you want to come back to this please feel free to reopen it! If you want to discuss this, please add a comment with: @sunpy/sunpy-developers and someone will get back to you soon.

github-actions[bot] avatar Feb 11 '25 05:02 github-actions[bot]