h2spec icon indicating copy to clipboard operation
h2spec copied to clipboard

h2spec generic/5 test 1 should not send an HTTP header with an empty value

Open gstrauss opened this issue 5 years ago • 2 comments

h2spec generic/5 test 1 should not send an HTTP header with an empty value. Such a header might be rejected by a server since a field-name: (empty value) is an invalid HTTP/1.1 header line.

h2spec generic/5 test 1 sends:

			// Indexed header field representation
			// (user-agent: )
			rep := []byte("\xba")

Is there a way for generic/5 test 1 (1: Sends a indexed header field representation) to send a valid header line? My server HPACK-decodes the request and returns 400 Bad Request, which passes the h2spec test. However, related to #120, if I return GOAWAY instead of 400 Bad Request, h2spec fails for generic/5 test 1.

gstrauss avatar Aug 28 '20 07:08 gstrauss

Patch proposed in https://github.com/summerwind/h2spec/issues/120#issuecomment-708103532 would make this a non-issue for me, though a valid header line is still preferred for correctness of the test.

gstrauss avatar Oct 14 '20 01:10 gstrauss

T

JohnMike8 avatar Aug 04 '21 07:08 JohnMike8