sumatrapdf icon indicating copy to clipboard operation
sumatrapdf copied to clipboard

3.6 themes explicit color definition

Open yn1046 opened this issue 1 year ago • 3 comments

What I did

Tried to redo the famous Dracula theme via the new Themes feature from 3.6 preview:

Themes [
	[
		Name = Dracula
		TextColor = #F8F8F2
		BackgroundColor = #282A36
		ControlBackgroundColor = #282A36
		LinkColor = #FF79C6
		ColorizeControls = true
	]
]

What I got

Because the text color (#F8F8F2) is a shade (an extremely white one) of yellow, some text colors are implicitly defined as varieties of yellow (e.g. disabled button text, disabled button selection, text links).

image

Proposal

Remove this confusing implicit color logic. The user should be able to define ALL the colors used in the UI explicitly in the Themes section of settings.

yn1046 avatar Dec 15 '24 18:12 yn1046

Hmm that themes site relies on suggesting non conventual settings so

Default Light is

Themes [
]

Default Dark is

Themes [
]

Theme = Dark from 3.5 is

Themes [
]

So the simplest is delete any custom "Themes" entries

GitHubRulesOK avatar Dec 15 '24 18:12 GitHubRulesOK

@GitHubRulesOK Not helpful and goes against the whole point of this issue. This is a request for explicit color definitions, not someone asking how to delete their custom theme.

MathisP75 avatar Feb 07 '25 14:02 MathisP75

I don't disagree although there is a cost to adding more colors: it makes creating themes harder.

This is relatively simple to do but tedious (has to determine which colors to define, add to settings, update themes and update the app to use those colors in appropriate places).

If someone wants to give it a try, that would be great.

kjk avatar Jun 06 '25 11:06 kjk