pkgbuilds icon indicating copy to clipboard operation
pkgbuilds copied to clipboard

bazelisk: support aarch64, fix version stamp

Open wijagels opened this issue 4 years ago • 5 comments

wijagels avatar May 29 '21 18:05 wijagels

Can I ask you to clarify whether or not you are talking about dogfooding the tool in order to build the non-binary package?

sudoforge avatar May 29 '21 18:05 sudoforge

Right, instead of grabbing a prebuilt bazelisk I'm using go build to create an intermediate copy of bazelisk to build the final bazelisk. Pretty much the same process as the bazelisk release script: https://github.com/bazelbuild/bazelisk/blob/master/build.sh

A simpler (and faster) approach would be to just call GOOS=linux GOARCH=amd64 go build -o bazel and package that.

wijagels avatar May 29 '21 18:05 wijagels

My apologies, my earlier comment was left when I was in the middle of a few things and I didn't get a chance to look at the diff that was proposed.

So, I'd prefer leaning toward a different approach to this, namely, providing architecture-specific sources instead of adding go as a makedep and increasing the overall build time of the package by daisy-chaining builds as this CL is currently doing.

I'm out of town for a wedding and am on mobile at the moment, but if you're open to refactoring the CL to take the general approach I suggested above I'd be happy to review and merge it when I have the chance later tonight or tomorrow morning (in a UTC-0700 time zone currently).

sudoforge avatar May 29 '21 19:05 sudoforge

A quick additional note -- I'd prefer avoiding using go directly as this can potentially lead to requiring additional steps that the build target defined in the BUILD file already covers; one of the main points of Bazel is to provide abstractions for building targets, and as that is what is used internally, it would be more canonical to follow that approach for this package.

sudoforge avatar May 29 '21 19:05 sudoforge

Makes sense, I updated the change to grab a bazel release and unpack that in the build directory. Let me know what you think of this solution.

wijagels avatar May 29 '21 21:05 wijagels