subspace icon indicating copy to clipboard operation
subspace copied to clipboard

Various build improvements

Open dmacvicar opened this issue 6 years ago • 3 comments

  • Switch to using go modules
    • go builddoes the right thing
    • Note: I did not check go.sum in, but it can also be done
  • Use go-bindata via go generate
    • go-bindata is fetched as any other dependency
  • Decouple build logic from the container
  • Allows to build the same without the container. Put the logic in a Makefile and use that in the container
  • Note that in any case there is no need for go getanymore

dmacvicar avatar Oct 10 '19 20:10 dmacvicar

With six open PRs, and no much happening, I am afraid the developer(s) aren't much active, if at all. 😢

Fastidious avatar Oct 11 '19 14:10 Fastidious

This project seems dead, and the maintainer its obviously missing, as proposal:

https://github.com/subspacecommunity/subspace

@dmacvicar I'm creating this and accepting any PR that seems logic, can I merge this fixes? or maybe do the PR e. I guess I'll spam this to all the other PRs.

agonbar avatar Mar 02 '20 16:03 agonbar

Thanks for merging those!

dmacvicar avatar Mar 04 '20 13:03 dmacvicar