subspace-desktop icon indicating copy to clipboard operation
subspace-desktop copied to clipboard

Application moves past `Syncing` screen before actually syncing.

Open ImmaZoni opened this issue 3 years ago • 4 comments

I have had multiple users explain that they will be syncing, then all of a sudden the subspace desktop will skip to 100% synced, and go the next screen showing it is fully synced. Or might show they are synced at an incorrect block as shown here https://forum.subspace.network/t/user-stuck-on-early-block/366

My best guess for what is happening is that the % bar on that screen is likely calculated by the nodes Best block #/Target block #

With the various forks nodes are jumping across we see various target block # heights, as such an edge case could appear where the best block #/target block # = 1 (true)

Which may send the application to the next screen even though syncing is not actually complete.

ImmaZoni avatar Jun 15 '22 18:06 ImmaZoni

Your assumption is true.

The problem is occurring at 2 different places: 1- plotting progress page -> when the ratio becomes 1 (due to incorrect heigh of the blockchain), the next button is enabled, and stays enabled. It should not stay enabled. When the ratio is not 1, it should disable the next button again 2- dashboard -> fully synced status is the last state, and there is no transition to any other state from fully synced state. There should a transition to syncing from fully synced as well, due to this potential incorrect block height information.

@isSerge , do you want to handle this? Or I can take care of it as well

ozgunozerk avatar Jun 16 '22 15:06 ozgunozerk

@ozgunozerk let me take this one

isSerge avatar Jun 16 '22 16:06 isSerge

In order to close this one, we need to update UI so there is a transition from synced back to syncing (in case of incorrect block height or any other changes)

isSerge avatar Jun 22 '22 10:06 isSerge

#238

achiurizo avatar Aug 02 '22 17:08 achiurizo