Tutorials icon indicating copy to clipboard operation
Tutorials copied to clipboard

Aachen Turbine Tutorial

Open alecappiello opened this issue 1 year ago • 6 comments

config and mesh files for the Aachen Turbine tutorial

alecappiello avatar Dec 17 '24 14:12 alecappiello

@joshkellyjak, could you review this PR?

alecappiello avatar Dec 17 '24 14:12 alecappiello

@joshkellyjak, could you review this PR?

Hey Josh, could you have a look at this, so that we can finally close it?

alecappiello avatar Jan 15 '25 11:01 alecappiello

Is this a copy of the test in TestCases?

Hi Pedro, the mesh is the same

alecappiello avatar Jan 16 '25 08:01 alecappiello

Then can we put this case in the tutorials.py regression and remove the one from TestCases?

pcarruscag avatar Jan 16 '25 16:01 pcarruscag

Then can we put this case in the tutorials.py regression and remove the one from TestCases?

Do you mean using this mesh in the tutorial files also for the regression test? If so, this change should not affect this PR. In case, could you guys give the final approve for this PR?

alecappiello avatar Feb 07 '25 14:02 alecappiello

Everything we put in tutorials must have a regression test in tutorials.py, no test, no approval.

pcarruscag avatar Feb 07 '25 16:02 pcarruscag