SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

Fix #2203: Improve Spanwise Section Error Handling in Turbomachinery Simulations

Open aryan0931 opened this issue 11 months ago • 2 comments

Proposed Changes

Fixes: #2203 This PR aims to:

This PR improves error messages for spanwise section calculations in turbomachinery simulations, addressing user experience

Related Work

Fixes #2203 : Wrong spanwise sections calculation in Turbomachinery simulation.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X] I am submitting my contribution to the develop branch.
  • [X] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [X] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • [ ] I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • [ ] I have added a test case that demonstrates my contribution, if necessary.
  • [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

aryan0931 avatar Mar 03 '25 16:03 aryan0931

This doesn't fix issue #2203 in that the issue of incorrectly determining calculating the spanwise boundary happens because of a bug in SU2, the mesh that is used in this issue is probably fine. I have also encountered this issue and checked the CGNS mesh and it is not malformed. All this PR does is add an additional error catch, please update the description to remove the fix.

joshkellyjak avatar Mar 03 '25 17:03 joshkellyjak

Thank you sir for review I will do the respective changes as soon as possible.

aryan0931 avatar Mar 03 '25 19:03 aryan0931

Are you going to finish this work @aryan0931?

pcarruscag avatar Jul 05 '25 22:07 pcarruscag