SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

[WIP] Implementation of Amplification Factor Transport(AFT) 2019b tranistion model

Open sun5k opened this issue 1 year ago • 2 comments

Proposed Changes

Hi, all.

This PR is for implementing well known subsonic transition model (SA-AFT2019b).

Coder's SA-AFT2019b model is composed of the amplification factor and the logarithmic intermittency transport equation as shown below. image

Current State

The primary implementation of the model has been completed and is now in the validation. The validation problems are refer : https://doi.org/10.2514/6.2023-3530 and https://doi.org/10.2514/6.2019-0039.

The transition onset location and the amplification factor field are slightly different. I'm still debugging and checking various things.

Validation Problem of Current State

Firstly, I'm trying the validation problem for 2-D problems (flat plate and NLF-0416 airfoil). The current results are shown below.

S&K Flat plate from https://doi.org/10.2514/6.2023-3530

image

NLF-0416 airfoil from https://doi.org/10.2514/6.2023-3530 image

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [ ] I am submitting my contribution to the develop branch.
  • [ ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [ ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • [ ] I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • [ ] I have added a test case that demonstrates my contribution, if necessary.
  • [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

sun5k avatar Jan 15 '25 13:01 sun5k

Thanks 👍 Looks good but we can re-use a lot of code from the LM solver and see the question about the aux var gradient which looks suspicious.

Thank you for comment @pcarruscag. I'll try to address each of your comments one by one.

For now, the SA-AFT2017b model is for testing purposes, so I'll delete the relevant parts.

sun5k avatar Jan 31 '25 07:01 sun5k

The original plan was to finish it before the new version (v8.2.0) was released, but I was busy and couldn't manage it. Now that I have some spare time, I'll start working on it again next week!

sun5k avatar May 20 '25 00:05 sun5k