SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

Minor 8.1.0 compilation issues on linux

Open yuriy-yarosh opened this issue 1 year ago • 4 comments

Describe the bug

Building 8.1.0 from source code on Archlinux with LLVM and stock (non su2) meson/ninja. I've installed python 3.13 with asdf and bundled meson.py script does not resolve the ninja PATH correctly.

While trying to build the code I've stumbled upon couple issues

  1. Posix definition for strict fileno usage externals/cgns/adf/ADF_internals.c requires #define _POSIX_SOURCE before including stdio.h for fileno implicit function definition to actually be resolved, over here tbe

pic

  1. Missing strings.h include in Metis externals/metis/GKlib/gkregex.c for strcasecmp to actually be resolved, over here tbe

pic

Desktop (please complete the following information):

  • OS: Arch
  • C++ compiler and version: llvm18.1.8 Python 3.13.1 ninja 1.12.1 meson 1.6.1 with asdf
  • MPI implementation and version: arch OpenMPI 5.0.6
  • SU2 Version: v8.1.0

yuriy-yarosh avatar Dec 30 '24 18:12 yuriy-yarosh

Thanks, let us know when the CGNS and METIS developers give you an update.

pcarruscag avatar Jan 02 '25 01:01 pcarruscag

@pcarruscag not sure if I've opened the issue in the correct metis repo, but CGNS folks had fixed that already and there's a PR due to C API cleanup effort.

yuriy-yarosh avatar Jan 03 '25 10:01 yuriy-yarosh

The METIS change is very simple so I would just open a PR to Prof. Karypis repo and another one to SU2 with the same update, we distribute METIS and ParMETIS with SU2 and the Apache 2 license allows modifying the source.

pcarruscag avatar Jan 03 '25 16:01 pcarruscag

Hello, is there a branch with this fix or is it still a WIP?

leminhman0312 avatar Mar 21 '25 10:03 leminhman0312