SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

Fix marker engine inflow

Open BerkeCan97 opened this issue 1 year ago • 4 comments

Proposed Changes

  • Added the missing config->SetInflow_Mach(iMarker_Inlet, Inlet_Mach_Total[iMarker_Inlet]) to CEulerSolver::GetPower_Properties
  • Added a new option,BC_EVAL_FREQ for setting the evaluation frequency for the Actuator Disk and Engine Markers, in order to control the stability of the marker.

Related Work

Fix for issue #2274 .

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X] I am submitting my contribution to the develop branch.
  • [X] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [X] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • [x] I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • [X] I have added a test case that demonstrates my contribution, if necessary.
  • [X] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

BerkeCan97 avatar May 11 '24 11:05 BerkeCan97

Hello

I am sorry if it is obvious but is there way to tell where the code style checks fails on the files? Looking at the the details section , only thing I can understand is that it failed to trim some trailing white spaces.

BerkeCan97 avatar Jun 13 '24 06:06 BerkeCan97

If you install the precommit hook it will take care of formatting for you https://su2code.github.io/docs_v7/Style-Guide/

pcarruscag avatar Jun 13 '24 14:06 pcarruscag

@BerkeCan97 can you run pre-commit on the files? We can then continue merging this.

bigfooted avatar Aug 10 '24 14:08 bigfooted

@BerkeCan97 can you run pre-commit on the files? We can then continue merging this.

Done, sorry it took so long.

BerkeCan97 avatar Aug 12 '24 06:08 BerkeCan97