[WIP] Add test case for 'FUEL' paper
Proposed Changes
This pull request adds the test case that we used for the Fuel paper.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
- [X] I am submitting my contribution to the develop branch.
- [X] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- [ ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- [ ] I used the pre-commit hook to prevent dirty commits and used
pre-commit run --allto format old commits. - [ ] I have added a test case that demonstrates my contribution, if necessary.
- [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
@danielmayer where does the python script for FADO go? here or in the Testcases repository?
@danielmayer where does the python script for FADO go? here or in the Testcases repository?
Good question. I think the purpose of the TestCases repo is to separate large files that don't change much from the code base. Since those scripts are small, I would lean towards putting them in the SU2 repo. Another option is to add them as a new test case to FADO, but that adds another layer of complexity. What do you think? What does @pcarruscag think?
TestCases repo is used for large files that are used in regression tests. Then we have the tutorials repo for tutorial files (mesh + configs) and we also exercise those in regressions. If this is too large for either of the above it should go into V&V, I guess that is how it was used for the paper?
If this is too large for either of the above it should go into V&V, I guess that is how it was used for the paper?
I suggest we add this to the regression tests, put the mesh in the testcases repo, and add additional scripts and results to the V&V and create a V&V page pointing to the paper and showing some main results.