[WIP] Fix NEMO Inlet BC

[jtneedels]

Proposed Changes

Fix NEMO inlet BC.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

• [x] I am submitting my contribution to the develop branch.
• [x] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
• [x] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
• [ ] I have added a test case that demonstrates my contribution, if necessary.
• [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

[jtneedels]

Need to figure out how to adapt for noneq flows. I haven't been able to find a separate description of how to solve for boundary conditions for noneq flows with Riemann invariants.

[jtneedels]

I've thought about this a bit, and I think the best way forward for this BC is to assume thermal equilibirum in the subsonic flow. In that case the ongoing characteristic for total density can be used to solve for the full thermodynamic state. I think this probably is consistent with use cases such as fuel injection in scramjets, where the injected fluid would be in thermodynamic equilibrium.

[jtneedels]

@pcarruscag PTAL what would be the best way to handle variable declarations with the switch statement? Either they all need to be pre-declared at the top of the function, or I can declare them inline and restrict the scope, but then the residual computation needs to take place in each case. Which of these ways would be preferred?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.