Benjamin Curtis
Benjamin Curtis
Yup, we'd merge a PR that added Standard and updated the code to pass its checks.
Yeah, it's probably better to throw away the work I did previously and start over on this. :)
I wonder if it would make sense to modify the existing appender instead of creating a new one. The [non-exception branch of the log method](https://github.com/reidmorrison/semantic_logger/blob/7f57034695ec59b7855ff686149b746db102d87d/lib/semantic_logger/appender/honeybadger.rb#L50-L58) could use `Honeybadger.event` to send...
> I considered that – it's a bit odd to use `semantic_logger` for exceptions when the honeybadger gem does it already. Unless I'm missing some clear benefit. Agreed :) >...
> Understandably we are calling it Honeybadger Events, since it uses the Event API, but they refer to overall solution as Honeybadger Insights: https://docs.honeybadger.io/guides/insights/ Can we rename the appender to...
Thanks for the issue! We definitely want to add support for events, but we don't have an ETA at the moment. PRs are welcome, of course. 😉 This is the...
Thanks for the suggestion! We'll take a look at adding this option after we address some other improvements.
Is this only in CI? You could probably squash this by setting the environment variable HONEYBADGER_INSIGHTS_ENABLED to false.
Thanks for the info! My guess is that the gem is trying to report events to the API and getting interrupted when the test run stops. If that's the case,...
There isn't an easy way to do that, but that's a great idea!