typescript-styled-plugin icon indicating copy to clipboard operation
typescript-styled-plugin copied to clipboard

`emmet.showExpandedAbbreviation: never` doesn't disable Emmet abbreviation autocomplete

Open karlhorky opened this issue 2 years ago • 3 comments

Hi there, first of all, thanks for this plugin! Very nice to have CSS features in JS/TS 🙌

I am using this plugin via the vscode-styled-components extension (https://github.com/styled-components/vscode-styled-components/pull/57 introduced Emmet into this extension)

However, I do not want to use Emmet at all. I don't mind if it would just appear and not break my workflow, but it causes some very strange things to happen when typing h1, h2, h3 within a css tagged template literal:

https://user-images.githubusercontent.com/1935696/141528952-9e2d7e3f-1b6b-4898-b487-2e690683a044.mp4

Apparently it should possible to disable Emmet with the settings below (which should work according to the VS Code docs and the typescript-styled-plugin docs)

  "emmet.showExpandedAbbreviation": "never",

However, this doesn't work.

The only way to disable this is with the following settings, which also disables other suggestions:

  "editor.quickSuggestions": {
    "other": false
  }

Originally reported in:

  • https://github.com/microsoft/typescript-styled-plugin/issues/154
  • https://github.com/styled-components/vscode-styled-components/issues/331

karlhorky avatar Apr 05 '23 07:04 karlhorky

@karlhorky did you want to have a go working on this? It shouldn't be too difficult. The styled components extension may need to send the setting up into the language server and from there we can choose not to show emmet.

The deno plugin receives an info object which has the config in it. You can see it here: https://github.com/denoland/vscode_deno/blob/main/typescript-deno-plugin/src/index.ts#L102-L111

This plugin is equivalent so it should be able to receive the same thing

jasonwilliams avatar Apr 05 '23 19:04 jasonwilliams

I have a bunch of feature work, ongoing projects and then open source work that would come ahead of this unfortunately, but maybe closer to summer / fall 2023 I'll have some time.

karlhorky avatar Apr 06 '23 07:04 karlhorky

Any updates regarding this issue? Emmet Abbreviations are a pain.

RageCrezz avatar Jan 05 '24 19:01 RageCrezz