wp-spider-cache icon indicating copy to clipboard operation
wp-spider-cache copied to clipboard

Feature request - Redis support

Open iMicknl opened this issue 10 years ago • 9 comments

I would like to have Redis support, because there is no decent page cache plugin at the moment that also supports Redis.

Would be nice to have support for:

  • HHVM's Redis extension
  • the PECL Redis Extension
  • Predis library for PHP (fallback). (https://github.com/nrk/predis) (like this plugin has: https://nl.wordpress.org/plugins/redis-cache/)

If you have a good idea how to merge this in easily, it would be very nice. Otherwise I will have a look the in next month, if I can add Redis support and open a PR.

iMicknl avatar Feb 29 '16 01:02 iMicknl

This would be awesome

fgilio avatar Mar 02 '16 17:03 fgilio

<3 +1!

stayallive avatar Mar 03 '16 12:03 stayallive

This would be very awesome. Anyone had a chance to try this out? PR's encouraged!

JJJ avatar Mar 30 '16 19:03 JJJ

+1 I can't help with a PR, but with testing.

renatonascalves avatar Jun 22 '16 14:06 renatonascalves

Could we enable wp-redis support in wp-spider-cache?

It is a high quality plugin.

szepeviktor avatar Feb 15 '17 19:02 szepeviktor

@JJJ I'd like to implement Redis support by wp-redis.

Could you start me up where to modify the existing code to switch engine?

szepeviktor avatar Feb 20 '17 22:02 szepeviktor

Why does WP Spider Cache need Redis support when WP Redis already has Redis support (and comprehensive test coverage to boot)?

danielbachhuber avatar Feb 21 '17 18:02 danielbachhuber

I've tried wp-redis + wp-spider-cache/advanced-cache.php based on https://github.com/stuttter/wp-spider-cache/issues/21#issuecomment-281373058

PHP Fatal error:  Uncaught Error: Class 'Memcache' not found in */wp-content/plugins/wp-spider-cache/wp-spider-cache/includes/base-object.php:246

szepeviktor avatar Feb 21 '17 18:02 szepeviktor

@szepeviktor I think what you're starting to do is a great approach:

  • Install both WP Spider Cache & WP Redis
  • Make changes to WP Spider Cache to work alongside WP Redis
  • Send PR's for any general improvements
  • Send PR's for WP Redis specific improvements

Long term, I can imagine bundling our own shim to work with whatever WP Redis provides, and/or relying on it entirely and adapting it's approach for our own internals.

JJJ avatar Feb 21 '17 21:02 JJJ