kplex icon indicating copy to clipboard operation
kplex copied to clipboard

Can't build development branch

Open jwillmer opened this issue 5 years ago • 6 comments

I like to get a docker image with the changes you merged into dev branch. But building the image returns the following:

image

jwillmer avatar Sep 09 '20 11:09 jwillmer

I believe the issue is that the Dutch file must have been done in UTF-16 on windows. I'm away on the boat at the moment, back this weekend. Can you try "dos2unix nl", then retry the install and see if that fixes it? If you can confirm that works on your system I'll make that change and push it when I get a chance

stripydog avatar Sep 09 '20 16:09 stripydog

Try the "fix-40" branch: it's just develop with the above conversion. If you confirm it fixes the problem I'll merge to develop

stripydog avatar Sep 09 '20 16:09 stripydog

If you merge https://github.com/stripydog/kplex/pull/41 then a docker image will auto build on each commit to dev branch. This way you will notice this immediately - and I don't need to test ;)

jwillmer avatar Sep 09 '20 21:09 jwillmer

I don’t merge anything to develop without testing in another branch first and my copy of gencat wasn’t throwing the same errors, so would appreciate if you could confirm this now works for you

stripydog avatar Sep 10 '20 07:09 stripydog

I tested myself even though my copies of gencat weren't throwing the same errors: seemed ok so I've merged it. Can you confirm this works OK now?

stripydog avatar Sep 15 '20 09:09 stripydog

Same error. Steps to reproduce:

  • checkout dev branch
  • execute docker build .

jwillmer avatar Sep 16 '20 10:09 jwillmer