Removed qs
Based off this comment https://github.com/stripe/stripe-node/issues/2038#issuecomment-2004751719
Includes a lightweight alternative to qs.stringify that can run in worker environments. I have added 80% of the tests from the qs library, if you think this is a good approach I can add the remainder. I wanted to confirm it is viable before I put any more time into it :)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Hi @gkiely. Thanks a lot for this PR! We would really appreciate if you could continue your work here 💯
Seems like the only failures are prettier-related?
@chenglou Our CI pipeline does not run the test suite until build failures are resolved first. We are waiting for @gkiely to make progress on this and add rest of the tests that they intend to add in this PR.
may I help with the PR?
Hi! Thanks for submitting, we'll watch the tagged issue!
Any reason why stripe cannot just use URLSearchParams ?
CI seems to be failing
Is this still happening? Removing qs would be great!
Yes, this would be amazing. qs adds an extra 18 (!) packages through transitive dependencies which is crazy for something that should be so simple
Hi @gkiely! Checking in to see if you still plan on continuing this work
@mbroshi-stripe would it be best to update the stringify function to add support for arrayFormat or alternatively this library supports all the qs options: https://github.com/payloadcms/qs-esm?
My main concern in adding a custom stringify/parse function is if later more functionality is needed.