stripe-node icon indicating copy to clipboard operation
stripe-node copied to clipboard

Removed qs

Open gkiely opened this issue 1 year ago • 13 comments

Based off this comment https://github.com/stripe/stripe-node/issues/2038#issuecomment-2004751719

Includes a lightweight alternative to qs.stringify that can run in worker environments. I have added 80% of the tests from the qs library, if you think this is a good approach I can add the remainder. I wanted to confirm it is viable before I put any more time into it :)

gkiely avatar Jun 23 '24 23:06 gkiely

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 23 '24 23:06 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 23 '24 23:06 CLAassistant

Hi @gkiely. Thanks a lot for this PR! We would really appreciate if you could continue your work here 💯

helenye-stripe avatar Jul 01 '24 23:07 helenye-stripe

Seems like the only failures are prettier-related?

chenglou avatar Jul 17 '24 08:07 chenglou

@chenglou Our CI pipeline does not run the test suite until build failures are resolved first. We are waiting for @gkiely to make progress on this and add rest of the tests that they intend to add in this PR.

prathmesh-stripe avatar Jul 25 '24 13:07 prathmesh-stripe

may I help with the PR?

v1rtl avatar Jan 23 '25 00:01 v1rtl

Hi! Thanks for submitting, we'll watch the tagged issue!

helenye-stripe avatar Jan 27 '25 14:01 helenye-stripe

Any reason why stripe cannot just use URLSearchParams ?

chyzwar avatar May 01 '25 13:05 chyzwar

CI seems to be failing

v1rtl avatar May 01 '25 14:05 v1rtl

Is this still happening? Removing qs would be great!

chenglou avatar May 01 '25 18:05 chenglou

Yes, this would be amazing. qs adds an extra 18 (!) packages through transitive dependencies which is crazy for something that should be so simple

vytskalt avatar May 08 '25 13:05 vytskalt

Hi @gkiely! Checking in to see if you still plan on continuing this work

mbroshi-stripe avatar May 21 '25 19:05 mbroshi-stripe

@mbroshi-stripe would it be best to update the stringify function to add support for arrayFormat or alternatively this library supports all the qs options: https://github.com/payloadcms/qs-esm?

My main concern in adding a custom stringify/parse function is if later more functionality is needed.

gkiely avatar Oct 12 '25 22:10 gkiely