stringer icon indicating copy to clipboard operation
stringer copied to clipboard

Support mobile, update zh-CN locales

Open guyskk opened this issue 7 years ago • 10 comments

  • Support mobile
  • Add turbolinks: https://github.com/turbolinks/turbolinks/blob/master/dist/turbolinks.js
  • Update zh-CN locales

Before:

stringer-story-old stringer-feeds-old

After:

stringer-story-new stringer-feeds-new

guyskk avatar Sep 02 '18 08:09 guyskk

I don't have permission to add translation in LocaleApp, how to participate in?

guyskk avatar Sep 02 '18 08:09 guyskk

Will this close #464?

duenni avatar Sep 02 '18 18:09 duenni

@duenni No, but I can fix it in next commit.

If you device has very small screen(eg: IPhone 4), the layout may broken.

When screen is 375x667 pixel: stringer-zero

When screen is 320x480 pixel: stringer-broker

guyskk avatar Sep 03 '18 00:09 guyskk

@duenni I just blamed the stylesheets source code, it shows the font-size not change in the last 5 years. So it's not caused by stringer updates, did you tried other browers and devices?

guyskk avatar Sep 03 '18 00:09 guyskk

No, I did not try other devices. It's an iPhone SE, resolution should be 1136 x 640 px.

duenni avatar Sep 03 '18 19:09 duenni

@guyskk I know it's been a couple of years, but are you still available to work on this? If so, I think it would be good to break up into separate PRs. One for the translations, one for the layout cleanups, and one for Turbolinks. I'm a little concerned about Turbolinks in particular, as that can cause issues depending on how the JavaScript is set up.

mockdeep avatar Feb 20 '21 19:02 mockdeep

Hi @mockdeep, I didn't use stringer for a long time, and I have build another RSS reader https://github.com/anyant/rssant .

Please feel free to use my code and commits if you need.

guyskk avatar Feb 21 '21 04:02 guyskk

@guyskk okay, I'll handle it, then. Thanks so much for contributing!

mockdeep avatar Feb 21 '21 19:02 mockdeep

@mockdeep would love to have those css fixes merged. Should I take over the fixing of this pr?

bitboxer avatar Apr 19 '22 09:04 bitboxer

@bitboxer that would be great! If you want to separate out the CSS changes, I'll be happy to review them and get them merged.

mockdeep avatar Apr 19 '22 16:04 mockdeep